feat(topic-events): clear out topic events when a topic is purged

NodeBB · Jan 27, 2021 · 0d4a377 · 0d4a377
1 parent 8e93bf7
commit 0d4a377
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/topics/delete.js b/src/topics/delete.js
@@ -98,6 +98,7 @@ module.exports = function (Topics) {
 			], tid),
 			deleteTopicFromCategoryAndUser(tid),
 			Topics.deleteTopicTags(tid),
+			Topics.events.purge(tid),
 			reduceCounters(tid),
 		]);
 		plugins.hooks.fire('action:topic.purge', { topic: deletedTopic, uid: uid });

diff --git a/src/topics/events.js b/src/topics/events.js
@@ -129,3 +129,12 @@ Events.log = async (tid, payload) => {
 	({ events } = await plugins.hooks.fire('filter:topic.events.log', { events }));
 	return events;
 };
+
+Events.purge = async (tid) => {
+	// Should only be called on topic purge
+	const keys = [`topic:${tid}:events`];
+	const eventIds = await db.getSortedSetRange(keys[0], 0, -1);
+	keys.push(...eventIds.map(id => `topicEvent:${id}`));
+
+	db.deleteAll(keys);
+};