fix: #9487, session data gathered during a session is lost upon login

e.g. returnTo, tids_viewed, etc.
NodeBB · Apr 14, 2021 · 1fee6a7 · 1fee6a7
1 parent f4c5050
commit 1fee6a7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/controllers/authentication.js b/src/controllers/authentication.js
@@ -328,7 +328,12 @@ authenticationController.doLogin = async function (req, uid) {
 	const loginAsync = util.promisify(req.login).bind(req);
 	const regenerateSession = util.promisify(req.session.regenerate).bind(req.session);
 
+	const sessionData = { ...req.session };
 	await regenerateSession();
+	for (const [prop, value] of Object.entries(sessionData)) {
+		req.session[prop] = value;
+	}
+
 	await loginAsync({ uid: uid });
 	await authenticationController.onSuccessfulLogin(req, uid);
 };