fix: missing req.body when parsing ActivityPub requests

NodeBB · Jul 11, 2023 · 239a1d7 · 239a1d7
1 parent 890e701
commit 239a1d7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/activitypub/index.js b/src/activitypub/index.js
@@ -194,6 +194,9 @@ ActivityPub.send = async (uid, targets, payload) => {
 			resolveWithFullResponse: true,
 		});
 
-		console.log(response.statusCode, response.body);
+		if (response.statusCode !== 201) {
+			// todo: i18n this
+			throw new Error('activity-failed');
+		}
 	}));
 };
diff --git a/src/controllers/activitypub/index.js b/src/controllers/activitypub/index.js
@@ -99,7 +99,7 @@ Controller.getInbox = async (req, res) => {
 };
 
 Controller.postInbox = async (req, res) => {
-	console.log(req.body);
+	console.log('received', req.body);
 
 	res.sendStatus(201);
 };

diff --git a/src/webserver.js b/src/webserver.js
@@ -230,7 +230,13 @@ function configureBodyParser(app) {
 	}
 	app.use(bodyParser.urlencoded(urlencodedOpts));
 
-	const jsonOpts = nconf.get('bodyParser:json') || {};
+	const jsonOpts = nconf.get('bodyParser:json') || {
+		type: [
+			'application/json',
+			'application/ld+json',
+			'application/activity+json',
+		],
+	};
 	app.use(bodyParser.json(jsonOpts));
 }