Skip to content

Commit

Permalink
fix: flag list tests due to breaking change in API
Browse files Browse the repository at this point in the history
  • Loading branch information
julianlam committed Aug 19, 2020
1 parent 07ebc81 commit 360aa00
Showing 1 changed file with 41 additions and 17 deletions.
58 changes: 41 additions & 17 deletions test/flags.js
Expand Up @@ -144,7 +144,10 @@ describe('Flags', function () {

describe('.list()', function () {
it('should show a list of flags (with one item)', function (done) {
Flags.list({}, 1, function (err, payload) {
Flags.list({
filters: {},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -164,8 +167,11 @@ describe('Flags', function () {
describe('(with filters)', function () {
it('should return a filtered list of flags if said filters are passed in', function (done) {
Flags.list({
state: 'open',
}, 1, function (err, payload) {
filters: {
state: 'open',
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -178,8 +184,11 @@ describe('Flags', function () {

it('should return no flags if a filter with no matching flags is used', function (done) {
Flags.list({
state: 'rejected',
}, 1, function (err, payload) {
filters: {
state: 'rejected',
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -192,8 +201,11 @@ describe('Flags', function () {

it('should return a flag when filtered by cid 1', function (done) {
Flags.list({
cid: 1,
}, 1, function (err, payload) {
filters: {
cid: 1,
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -206,8 +218,11 @@ describe('Flags', function () {

it('shouldn\'t return a flag when filtered by cid 2', function (done) {
Flags.list({
cid: 2,
}, 1, function (err, payload) {
filters: {
cid: 2,
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -220,8 +235,11 @@ describe('Flags', function () {

it('should return a flag when filtered by both cid 1 and 2', function (done) {
Flags.list({
cid: [1, 2],
}, 1, function (err, payload) {
filters: {
cid: [1, 2],
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -234,9 +252,12 @@ describe('Flags', function () {

it('should return one flag if filtered by both cid 1 and 2 and open state', function (done) {
Flags.list({
cid: [1, 2],
state: 'open',
}, 1, function (err, payload) {
filters: {
cid: [1, 2],
state: 'open',
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand All @@ -249,9 +270,12 @@ describe('Flags', function () {

it('should return no flag if filtered by both cid 1 and 2 and non-open state', function (done) {
Flags.list({
cid: [1, 2],
state: 'resolved',
}, 1, function (err, payload) {
filters: {
cid: [1, 2],
state: 'resolved',
},
uid: 1,
}, function (err, payload) {
assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page'));
Expand Down

0 comments on commit 360aa00

Please sign in to comment.