Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: taskbar icon not pushed via composer/persona
@Antosik, partially reverted your PR: 342503e just specifically this file: https://github.com/NodeBB/NodeBB/blob/342503e07add0edd135549b8f554b6ffa6df830d/public/src/modules/taskbar.js I'm not 100% sure, but it might be because this hook is called sooner than the hook being registered? https://github.com/NodeBB/nodebb-theme-persona/blob/master/public/persona.js#L100-L101 @julianlam
- Loading branch information
3a81c8f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Antosik, just letting you know we will un-revert it once we resolve on persona, etc.
I should have waited a bit longer to get the other plugins/themes ready first before we accepted the PR but no worries, just wanted to say thanks and we will re-add this soon once we figure it out.
@julianlam @barisusakli