fix: don't try to parse response if request is head #11960

NodeBB · Aug 29, 2023 · 440299e · 440299e
1 parent 50d4477
commit 440299e
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/public/src/modules/api.js b/public/src/modules/api.js
@@ -69,18 +69,23 @@ async function xhr(options, cb) {
 	const isJSON = contentType && contentType.startsWith('application/json');
 
 	let response;
-	if (isJSON) {
-		response = await res.json();
-	} else {
-		response = await res.text();
+	if (options.method !== 'head') {
+		if (isJSON) {
+			response = await res.json();
+		} else {
+			response = await res.text();
+		}
 	}
 
 	if (!res.ok) {
-		return cb(new Error(isJSON ? response.status.message : response));
+		if (response) {
+			return cb(new Error(isJSON ? response.status.message : response));
+		}
+		return cb(new Error(res.statusText));
 	}
 
 	cb(null, (
-		isJSON && response.hasOwnProperty('status') && response.hasOwnProperty('response') ?
+		isJSON && response && response.hasOwnProperty('status') && response.hasOwnProperty('response') ?
 			response.response :
 			response
 	));