fix: don't crash if content is undefined

NodeBB · Jul 22, 2020 · 4658121 · 4658121
1 parent 5a5abf3
commit 4658121
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/socket.io/index.js b/src/socket.io/index.js
@@ -150,6 +150,7 @@ async function onMessage(socket, payload) {
 			});
 		}
 	} catch (err) {
+		winston.error(err.stack ? err.stack : err.message);
 		callback({ message: err.message });
 	}
 }

diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js
@@ -178,7 +178,10 @@ SocketPosts.editQueuedContent = async function (socket, data) {
 		throw new Error('[[error:invalid-data]]');
 	}
 	await posts.editQueuedContent(socket.uid, data.id, data.content, data.title);
-	return await plugins.fireHook('filter:parse.post', { postData: data });
+	if (data.content) {
+		return await plugins.fireHook('filter:parse.post', { postData: data });
+	}
+	return { postData: data };
 };
 
 require('../promisify')(SocketPosts);