fix: #7448

don't set parent to itself
NodeBB · Mar 13, 2019 · 4732bed · 4732bed
1 parent 8029314
commit 4732bed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/categories/create.js b/src/categories/create.js
@@ -153,7 +153,7 @@ module.exports = function (Categories) {
 
 				const oldParent = parseInt(destination.parentCid, 10) || 0;
 				const newParent = parseInt(results.source.parentCid, 10) || 0;
-				if (copyParent) {
+				if (copyParent && newParent !== parseInt(toCid, 10)) {
 					tasks.push(async.apply(db.sortedSetRemove, 'cid:' + oldParent + ':children', toCid));
 					tasks.push(async.apply(db.sortedSetAdd, 'cid:' + newParent + ':children', results.source.order, toCid));
 					tasks.push(function (next) {