fix: move check inside lock

NodeBB · Jul 25, 2020 · 5713576 · 5713576
1 parent af91c26
commit 5713576
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/user/create.js b/src/user/create.js
@@ -15,13 +15,14 @@ module.exports = function (User) {
 			data.email = String(data.email).trim();
 		}
 
-		await User.isDataValid(data);
-
 		try {
 			await lock(data.username, '[[error:username-taken]]');
 			if (data.email) {
 				await lock(data.email, '[[error:email-taken]]');
 			}
+
+			await User.isDataValid(data);
+
 			return await create(data);
 		} finally {
 			await db.deleteObjectFields('locks', [data.username, data.email]);