fix: let recent replies respect oldest/newest sort settings

NodeBB · Apr 11, 2021 · 60eed8d · 60eed8d
1 parent 0f249aa
commit 60eed8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/public/src/client/topic/replies.js b/public/src/client/topic/replies.js
@@ -66,7 +66,11 @@ define('forum/topic/replies', ['navigator', 'components', 'forum/topic/posts'],
 		app.parseAndTranslate('topic', 'posts', data, function (html) {
 			var replies = $('[component="post"][data-pid="' + post.toPid + '"] [component="post/replies"]').first();
 			if (replies.length) {
-				replies.append(html);
+				if (config.topicPostSort === 'newest_to_oldest') {
+					replies.prepend(html);
+				} else {
+					replies.append(html);
+				}
 				posts.onNewPostsAddedToDom(html);
 			}
 		});

diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js
@@ -116,8 +116,8 @@ SocketPosts.getReplies = async function (socket, pid) {
 	if (!utils.isNumber(pid)) {
 		throw new Error('[[error:invalid-data]]');
 	}
-
-	const pids = await posts.getPidsFromSet(`pid:${pid}:replies`, 0, -1, false);
+	const { topicPostSort } = await user.getSettings(socket.uid);
+	const pids = await posts.getPidsFromSet(`pid:${pid}:replies`, 0, -1, topicPostSort === 'newest_to_oldest');
 
 	let [postData, postPrivileges] = await Promise.all([
 		posts.getPostsByPids(pids, socket.uid),