refactor: shorter timeago

NodeBB · Oct 6, 2023 · 6149252 · 6149252
1 parent ff952e5
commit 6149252
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/public/src/client/topic/posts.js b/public/src/client/topic/posts.js
@@ -341,22 +341,18 @@ define('forum/topic/posts', [
 
 			const diff = post.attr('data-timestamp') - prev.attr('data-timestamp');
 			if (Math.abs(diff) >= necroThreshold) {
-				const suffixAgo = $.timeago.settings.strings.suffixAgo;
-				const prefixAgo = $.timeago.settings.strings.prefixAgo;
-				const suffixFromNow = $.timeago.settings.strings.suffixFromNow;
-				const prefixFromNow = $.timeago.settings.strings.prefixFromNow;
-
-				$.timeago.settings.strings.suffixAgo = '';
-				$.timeago.settings.strings.prefixAgo = '';
-				$.timeago.settings.strings.suffixFromNow = '';
-				$.timeago.settings.strings.prefixFromNow = '';
+				const props = ['suffixAgo', 'prefixAgo', 'suffixFromNow', 'prefixFromNow'];
+				const savedProps = {};
+				props.forEach((prop) => {
+					savedProps[prop] = $.timeago.settings.strings[prop];
+					$.timeago.settings.strings[prop] = '';
+				});
 
 				const translationText = (diff > 0 ? '[[topic:timeago-later,' : '[[topic:timeago-earlier,') + $.timeago.inWords(diff) + ']]';
 
-				$.timeago.settings.strings.suffixAgo = suffixAgo;
-				$.timeago.settings.strings.prefixAgo = prefixAgo;
-				$.timeago.settings.strings.suffixFromNow = suffixFromNow;
-				$.timeago.settings.strings.prefixFromNow = prefixFromNow;
+				props.forEach((prop) => {
+					$.timeago.settings.strings[prop] = savedProps[prop];
+				});
 				const html = await app.parseAndTranslate('partials/topic/necro-post', { text: translationText });
 				html.attr('data-necro-post-index', prev.attr('data-index'));
 				html.insertBefore(post);