Skip to content

Commit

Permalink
fix: dont save data for non-positive uids
Browse files Browse the repository at this point in the history
  • Loading branch information
barisusakli committed Dec 14, 2018
1 parent 63f4b56 commit 62f01a8
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
6 changes: 5 additions & 1 deletion src/controllers/authentication.js
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,11 @@ authenticationController.onSuccessfulLogin = function (req, uid, callback) {
user.auth.addSession(uid, req.sessionID, next);
},
function (next) {
db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID, next);
if (uid > 0) {
db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID, next);
} else {
next();
}
},
function (next) {
user.updateLastOnlineTime(uid, next);
Expand Down
12 changes: 5 additions & 7 deletions src/user/admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ var plugins = require('../plugins');

module.exports = function (User) {
User.logIP = function (uid, ip, callback) {
if (!(parseInt(uid, 10) > 0)) {
return setImmediate(callback);
}
var now = Date.now();
async.waterfall([
function (next) {
Expand All @@ -31,10 +34,7 @@ module.exports = function (User) {
db.getSortedSetRevRange('uid:' + uid + ':ip', 0, stop, next);
},
function (ips, next) {
ips = ips.map(function (ip) {
return validator.escape(String(ip));
});
next(null, ips);
next(null, ips.map(ip => validator.escape(String(ip))));
},
], callback);
};
Expand All @@ -48,9 +48,7 @@ module.exports = function (User) {
db.getSortedSetRangeWithScores('username:uid', 0, -1, next);
},
function (users, next) {
uids = users.map(function (user) {
return user.score;
});
uids = users.map(user => user.score);
plugins.fireHook('filter:user.csvFields', { fields: ['uid', 'email', 'username'] }, next);
},
function (data, next) {
Expand Down
3 changes: 3 additions & 0 deletions src/user/auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ module.exports = function (User) {

User.auth.addSession = function (uid, sessionId, callback) {
callback = callback || function () {};
if (!(parseInt(uid, 10) > 0)) {
return setImmediate(callback);
}
db.sortedSetAdd('uid:' + uid + ':sessions', Date.now(), sessionId, callback);
};

Expand Down

0 comments on commit 62f01a8

Please sign in to comment.