feat: allow passing in container to threadTools

NodeBB · Sep 15, 2020 · 7148be2 · 7148be2
1 parent 99f24c5
commit 7148be2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/public/src/client/topic.js b/public/src/client/topic.js
@@ -46,7 +46,7 @@ define('forum/topic', [
 		posts.onTopicPageLoad(components.get('post'));
 
 		postTools.init(tid);
-		threadTools.init(tid);
+		threadTools.init(tid, $('.topic'));
 		events.init();
 
 		sort.handleSort('topicPostSort', 'user.setTopicSort', 'topic/' + ajaxify.data.slug);

diff --git a/public/src/client/topic/threadTools.js b/public/src/client/topic/threadTools.js
@@ -7,10 +7,8 @@ define('forum/topic/threadTools', [
 ], function (components, translator) {
 	var ThreadTools = {};
 
-	ThreadTools.init = function (tid) {
-		renderMenu();
-
-		var topicContainer = $('.topic');
+	ThreadTools.init = function (tid, topicContainer) {
+		renderMenu(topicContainer);
 
 		topicContainer.on('click', '[component="topic/delete"]', function () {
 			topicCommand('delete', tid);
@@ -139,8 +137,8 @@ define('forum/topic/threadTools', [
 		}
 	};
 
-	function renderMenu() {
-		$('.topic').on('show.bs.dropdown', '.thread-tools', function () {
+	function renderMenu(container) {
+		container.on('show.bs.dropdown', '.thread-tools', function () {
 			var $this = $(this);
 			var dropdownMenu = $this.find('.dropdown-menu');
 			if (dropdownMenu.html()) {

diff --git a/public/src/modules/sort.js b/public/src/modules/sort.js
@@ -10,17 +10,19 @@ define('sort', ['components'], function (components) {
 		var currentSetting = threadSort.find('a[data-sort="' + config[field] + '"]');
 		currentSetting.find('i').addClass('fa-check');
 
-		$('.category, .topic').on('click', '[component="thread/sort"] a', function () {
-			var newSetting = $(this).attr('data-sort');
-			socket.emit(method, newSetting, function (err) {
-				if (err) {
-					return app.alertError(err.message);
-				}
-				config[field] = newSetting;
-				var qs = decodeURIComponent($.param(utils.params()));
-				ajaxify.go(gotoOnSave + (qs ? '?' + qs : ''));
+		$('body')
+			.off('click', '[component="thread/sort"] a')
+			.on('click', '[component="thread/sort"] a', function () {
+				var newSetting = $(this).attr('data-sort');
+				socket.emit(method, newSetting, function (err) {
+					if (err) {
+						return app.alertError(err.message);
+					}
+					config[field] = newSetting;
+					var qs = decodeURIComponent($.param(utils.params()));
+					ajaxify.go(gotoOnSave + (qs ? '?' + qs : ''));
+				});
 			});
-		});
 	};
 
 	return module;