fix: reverse uid checks

NodeBB · Jul 29, 2020 · 7331fae · 7331fae
1 parent 303bffd
commit 7331fae
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/groups/membership.js b/src/groups/membership.js
@@ -4,7 +4,6 @@ const _ = require('lodash');
 
 const db = require('../database');
 const user = require('../user');
-
 const cache = require('../cache');
 
 module.exports = function (Groups) {
@@ -25,7 +24,7 @@ module.exports = function (Groups) {
 	};
 
 	Groups.isMember = async function (uid, groupName) {
-		if (!uid || parseInt(uid, 10) <= 0 || !groupName) {
+		if (!uid || !(parseInt(uid, 10) > 0) || !groupName) {
 			return false;
 		}
 
@@ -66,7 +65,7 @@ module.exports = function (Groups) {
 	};
 
 	Groups.isMemberOfGroups = async function (uid, groups) {
-		if (!uid || parseInt(uid, 10) <= 0 || !groups.length) {
+		if (!uid || !(parseInt(uid, 10) > 0) || !groups.length) {
 			return groups.map(groupName => groupName === 'guests');
 		}
 		const cachedData = {};