fix: #12009, check if suggested/current versions are valid

NodeBB · Sep 15, 2023 · 7ca37bd · 7ca37bd
1 parent f9323de
commit 7ca37bd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/cli/upgrade-plugins.js b/src/cli/upgrade-plugins.js
@@ -106,7 +106,7 @@ async function checkPlugins() {
 		current = plugins[suggestObj.package];
 		suggested = suggestObj.version;
 
-		if (suggestObj.code === 'match-found' && semver.gt(suggested, current)) {
+		if (suggestObj.code === 'match-found' && semver.valid(current) && semver.valid(suggested) && semver.gt(suggested, current)) {
 			return {
 				name: suggestObj.package,
 				current: current,