fix: #12389, update privilege group check

NodeBB · Mar 5, 2024 · 87a7905 · 87a7905
1 parent 22c225c
commit 87a7905
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/groups/index.js b/src/groups/index.js
@@ -56,7 +56,7 @@ Groups.removeEphemeralGroups = function (groups) {
 	return groups;
 };
 
-const isPrivilegeGroupRegex = /^cid:(?:\d+|admin):privileges:[\w\-:]+$/;
+const isPrivilegeGroupRegex = /^cid:(?:-?\d+|admin):privileges:[\w\-:]+$/;
 Groups.isPrivilegeGroup = function (groupName) {
 	return isPrivilegeGroupRegex.test(groupName);
 };

diff --git a/src/plugins/hooks.js b/src/plugins/hooks.js
@@ -233,7 +233,7 @@ function hookHandlerPromise(hook, hookObj, params) {
 		if (hook.startsWith('filter:') && returned !== undefined) {
 			_resolve(returned);
 		} else if (hook.startsWith('static:') && hookObj.method.length <= 1) {
-			// make sure it is resolved if static hook doesn't return anything and doesn't use callback
+			// make sure it is resolved if static hook doesn't use callback
 			_resolve();
 		}
 	});