fix: closes #12246, direction is passed in as string as query param w…

…ith new api call cid isn't necessary in query params since its in path
NodeBB · Dec 27, 2023 · 8867f24 · 8867f24
1 parent a74b514
commit 8867f24
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/public/src/client/category.js b/public/src/client/category.js
@@ -127,7 +127,6 @@ define('forum/category', [
 		hooks.fire('action:topics.loading');
 		const params = utils.params();
 		infinitescroll.loadMore(`/categories/${ajaxify.data.cid}/topics`, {
-			cid: ajaxify.data.cid,
 			after: after,
 			direction: direction,
 			query: params,

diff --git a/src/api/categories.js b/src/api/categories.js
@@ -128,7 +128,7 @@ categoriesAPI.getTopics = async (caller, data) => {
 
 	let start = Math.max(0, parseInt(data.after || 0, 10));
 
-	if (data.direction === -1) {
+	if (parseInt(data.direction, 10) === -1) {
 		start -= infScrollTopicsPerPage;
 	}
 

diff --git a/src/socket.io/topics/infinitescroll.js b/src/socket.io/topics/infinitescroll.js
@@ -30,7 +30,7 @@ module.exports = function (SocketTopics) {
 			parseInt(data.count, 10) || meta.config.postsPerPage || 20
 		));
 
-		if (data.direction === -1) {
+		if (parseInt(data.direction, 10) === -1) {
 			start -= infScrollPostsPerPage;
 		}