fix: don't allow duplicate upgrade script names

NodeBB · Aug 7, 2020 · 8887f0e · 8887f0e
1 parent f4c986a
commit 8887f0e
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/src/upgrade.js b/src/upgrade.js
@@ -41,6 +41,23 @@ Upgrade.getAll = function (callback) {
 			}));
 		},
 		async.apply(Upgrade.appendPluginScripts),
+		function (files, next) {
+			// check duplicates and error
+			const seen = {};
+			const dupes = [];
+			files.forEach((file) => {
+				if (seen[file]) {
+					dupes.push(file);
+				} else {
+					seen[file] = true;
+				}
+			});
+			if (dupes.length) {
+				winston.error('Found duplicate upgrade scripts\n' + dupes);
+				return next(new Error('[[error:duplicate-upgrade-scripts]]'));
+			}
+			setImmediate(next);
+		},
 	], callback);
 };