fix: sort setting not using correct field name

NodeBB · Oct 28, 2020 · 9082062 · 9082062
1 parent c443129
commit 9082062
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/public/src/client/category.js b/public/src/client/category.js
@@ -24,7 +24,7 @@ define('forum/category', [
 
 		topicList.init('category', loadTopicsAfter);
 
-		sort.handleSort('categoryTopicSort', 'setCategorySort', 'category/' + ajaxify.data.slug);
+		sort.handleSort('categoryTopicSort', 'category/' + ajaxify.data.slug);
 
 		if (!config.usePagination) {
 			navigator.init('[component="category/topic"]', ajaxify.data.topic_count, Category.toTop, Category.toBottom, Category.navigatorCallback);

diff --git a/public/src/client/topic.js b/public/src/client/topic.js
@@ -49,7 +49,7 @@ define('forum/topic', [
 		threadTools.init(tid, $('.topic'));
 		events.init();
 
-		sort.handleSort('topicPostSort', 'setTopicSort', 'topic/' + ajaxify.data.slug);
+		sort.handleSort('topicPostSort', 'topic/' + ajaxify.data.slug);
 
 		if (!config.usePagination) {
 			infinitescroll.init($('[component="topic"]'), posts.loadMorePosts);

diff --git a/public/src/modules/sort.js b/public/src/modules/sort.js
@@ -4,7 +4,7 @@
 define('sort', ['components', 'api'], function (components, api) {
 	var module = {};
 
-	module.handleSort = function (field, key, gotoOnSave) {
+	module.handleSort = function (field, gotoOnSave) {
 		var threadSort = components.get('thread/sort');
 		threadSort.find('i').removeClass('fa-check');
 		var currentSetting = threadSort.find('a[data-sort="' + config[field] + '"]');
@@ -20,7 +20,7 @@ define('sort', ['components', 'api'], function (components, api) {
 				}
 				var newSetting = $(this).attr('data-sort');
 				if (app.user.uid) {
-					api.put(`/users/${app.user.uid}/settings/${key}`, {
+					api.put(`/users/${app.user.uid}/settings/${field}`, {
 						value: newSetting,
 					}).then(() => {
 						refresh(newSetting, utils.params());