fix: callbacks

NodeBB · Mar 15, 2019 · b48b6d7 · b48b6d7
1 parent f8fa659
commit b48b6d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/database/redis/hash.js b/src/database/redis/hash.js
@@ -63,13 +63,13 @@ module.exports = function (redisClient, module) {
 
 	module.getObjects = function (keys, callback) {
 		var cachedData = {};
-		function getFromCache() {
-			process.nextTick(callback, null, keys.map(key => _.clone(cachedData[key])));
+		function getFromCache(next) {
+			process.nextTick(next, null, keys.map(key => _.clone(cachedData[key])));
 		}
 
 		const unCachedKeys = cache.getUnCachedKeys(keys, cachedData);
 		if (!unCachedKeys.length) {
-			return getFromCache();
+			return getFromCache(callback);
 		}
 
 		async.waterfall([
@@ -86,7 +86,7 @@ module.exports = function (redisClient, module) {
 					cache.set(key, cachedData[key]);
 				});
 
-				getFromCache();
+				getFromCache(next);
 			},
 		], callback);
 	};

diff --git a/src/groups/membership.js b/src/groups/membership.js
@@ -162,8 +162,8 @@ module.exports = function (Groups) {
 
 	Groups.isMembers = function (uids, groupName, callback) {
 		var cachedData = {};
-		function getFromCache() {
-			setImmediate(callback, null, uids.map(uid => cachedData[uid + ':' + groupName]));
+		function getFromCache(next) {
+			setImmediate(next, null, uids.map(uid => cachedData[uid + ':' + groupName]));
 		}
 		if (!groupName || !uids.length) {
 			return setImmediate(callback, null, uids.map(() => false));