fix: #12090, dont award disabled rewards

NodeBB · Oct 16, 2023 · c1ae879 · c1ae879
1 parent 347a43f
commit c1ae879
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/rewards/index.js b/src/rewards/index.js
@@ -15,8 +15,9 @@ rewards.checkConditionAndRewardUser = async function (params) {
 	}
 	const ids = await getIDsByCondition(condition);
 	let rewardData = await getRewardDataByIDs(ids);
+	// filter disabled
+	rewardData = rewardData.filter(r => r && !(r.disabled === 'true' || r.disabled === true));
 	rewardData = await filterCompletedRewards(uid, rewardData);
-	rewardData = rewardData.filter(Boolean);
 	if (!rewardData || !rewardData.length) {
 		return;
 	}