fix: skip elements if they dont have proper index

NodeBB · Sep 15, 2020 · c9c9dd2 · c9c9dd2
1 parent 9cde510
commit c9c9dd2
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/public/src/modules/navigator.js b/public/src/modules/navigator.js
@@ -225,15 +225,17 @@ define('navigator', ['forum/pagination', 'components'], function (pagination, co
 		var middleOfViewport = scrollTop + (windowHeight / 2);
 		var previousDistance = Number.MAX_VALUE;
 		els.each(function () {
-			var distanceToMiddle = Math.abs(middleOfViewport - $(this).offset().top);
-
-			if (distanceToMiddle > previousDistance) {
-				return false;
-			}
+			var elIndex = parseInt($(this).attr('data-index'), 10);
+			if (elIndex >= 0) {
+				var distanceToMiddle = Math.abs(middleOfViewport - $(this).offset().top);
+				if (distanceToMiddle > previousDistance) {
+					return false;
+				}
 
-			if (distanceToMiddle < previousDistance) {
-				index = parseInt($(this).attr('data-index'), 10) + 1;
-				previousDistance = distanceToMiddle;
+				if (distanceToMiddle < previousDistance) {
+					index = elIndex + 1;
+					previousDistance = distanceToMiddle;
+				}
 			}
 		});