properly fixing #4583

NodeBB · Apr 29, 2016 · cb1920d · cb1920d
1 parent bd8fcb5
commit cb1920d
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/src/posts/flags.js b/src/posts/flags.js
@@ -85,10 +85,24 @@ module.exports = function(Posts) {
 					], pid, next);
 				});
 			},
+			function(next) {
+				async.series([
+					function(next) {
+						db.getSortedSetRange('pid:' + pid + ':flag:uids', 0, -1, function(err, uids) {
+							async.each(uids, function(uid, next) {
+								var nid = 'post_flag:' + pid + ':uid:' + uid;
+								async.parallel([
+									async.apply(db.delete, 'notifications:' + nid),
+									async.apply(db.sortedSetRemove, 'notifications', 'post_flag:' + pid + ':uid:' + uid)
+								], next);
+							}, next);
+						});
+					},
+					async.apply(db.delete, 'pid:' + pid + ':flag:uids')
+				], next);
+			},
 			async.apply(db.deleteObjectField, 'post:' + pid, 'flags'),
-			async.apply(db.delete, 'pid:' + pid + ':flag:uids'),
-			async.apply(db.delete, 'pid:' + pid + ':flag:uid:reason'),
-			async.apply(db.sortedSetRemove, 'notifications', 'post_flag:' + pid + ':uid:' + uid)
+			async.apply(db.delete, 'pid:' + pid + ':flag:uid:reason')
 		], function(err) {
 			callback(err);
 		});