Skip to content

Commit

Permalink
Merge branch 'master' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
barisusakli committed May 21, 2024
2 parents 2fef27a + 83facb7 commit d61b021
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 5 deletions.
61 changes: 61 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,64 @@
#### v3.8.1 (2024-05-15)

##### Chores

* incrementing version number - v3.8.0 (e228a6eb)
* update changelog for v3.8.0 (2ef2750d)
* incrementing version number - v3.7.5 (6882894d)
* incrementing version number - v3.7.4 (6678744c)
* incrementing version number - v3.7.3 (2d62b6f6)
* incrementing version number - v3.7.2 (cc257e7e)
* incrementing version number - v3.7.1 (712365a5)
* incrementing version number - v3.7.0 (9a6153d7)
* incrementing version number - v3.6.7 (86a17e38)
* incrementing version number - v3.6.6 (6604bf37)
* incrementing version number - v3.6.5 (6c653625)
* incrementing version number - v3.6.4 (83d131b4)
* incrementing version number - v3.6.3 (fc7d2bfd)
* incrementing version number - v3.6.2 (0f577a57)
* incrementing version number - v3.6.1 (f1a69468)
* incrementing version number - v3.6.0 (4cdf85f8)
* incrementing version number - v3.5.3 (ed0e8783)
* incrementing version number - v3.5.2 (52fbb2da)
* incrementing version number - v3.5.1 (4c543488)
* incrementing version number - v3.5.0 (d06fb4f0)
* incrementing version number - v3.4.3 (5c984250)
* incrementing version number - v3.4.2 (3f0dac38)
* incrementing version number - v3.4.1 (01e69574)
* incrementing version number - v3.4.0 (fd9247c5)
* incrementing version number - v3.3.9 (5805e770)
* incrementing version number - v3.3.8 (a5603565)
* incrementing version number - v3.3.7 (b26f1744)
* incrementing version number - v3.3.6 (7fb38792)
* incrementing version number - v3.3.4 (a67f84ea)
* incrementing version number - v3.3.3 (f94d239b)
* incrementing version number - v3.3.2 (ec9dac97)
* incrementing version number - v3.3.1 (151cc68f)
* incrementing version number - v3.3.0 (fc1ad70f)
* incrementing version number - v3.2.3 (b06d3e63)
* incrementing version number - v3.2.2 (758ecfcd)
* incrementing version number - v3.2.1 (20145074)
* incrementing version number - v3.2.0 (9ecac38e)
* incrementing version number - v3.1.7 (0b4e81ab)
* incrementing version number - v3.1.6 (b3a3b130)
* incrementing version number - v3.1.5 (ec19343a)
* incrementing version number - v3.1.4 (2452783c)
* incrementing version number - v3.1.3 (3b4e9d3f)
* incrementing version number - v3.1.2 (40fa3489)
* incrementing version number - v3.1.1 (40250733)
* incrementing version number - v3.1.0 (0cb386bd)
* incrementing version number - v3.0.1 (26f6ea49)
* incrementing version number - v3.0.0 (224e08cd)

##### Bug Fixes

* wrong mention version (1d1f499b)

##### Tests

* use node 20 (a40f54aa)
* remove node 18 (6bd22e53)

#### v3.8.0 (2024-05-15)

##### Chores
Expand Down
4 changes: 2 additions & 2 deletions install/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nodebb",
"license": "GPL-3.0",
"description": "NodeBB Forum",
"version": "3.8.0",
"version": "3.8.1",
"homepage": "https://www.nodebb.org",
"repository": {
"type": "git",
Expand Down Expand Up @@ -94,7 +94,7 @@
"multiparty": "4.2.3",
"nconf": "0.12.1",
"nodebb-plugin-2factor": "7.5.1",
"nodebb-plugin-composer-default": "10.2.35",
"nodebb-plugin-composer-default": "10.2.36",
"nodebb-plugin-dbsearch": "6.2.3",
"nodebb-plugin-emoji": "5.1.15",
"nodebb-plugin-emoji-android": "4.0.0",
Expand Down
5 changes: 4 additions & 1 deletion public/src/modules/topicThumbs.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ define('topicThumbs', [

Thumbs.modal.handleDelete = (payload) => {
const modalEl = payload.modal.get(0);

const { id: uuid } = payload;
modalEl.addEventListener('click', (ev) => {
if (ev.target.closest('button[data-action="remove"]')) {
bootbox.confirm('[[modules:thumbs.modal.confirm-remove]]', (ok) => {
Expand All @@ -101,6 +101,9 @@ define('topicThumbs', [
path: path,
}).then(() => {
Thumbs.modal.open(payload);
require(['composer'], (composer) => {
composer.updateThumbCount(uuid, $(`[component="composer"][data-uuid="${uuid}"]`));
});
}).catch(alerts.error);
});
}
Expand Down
12 changes: 10 additions & 2 deletions src/middleware/render.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,21 @@ module.exports = function (middleware) {
res.set('cache-control', 'private');
}

const buildResult = await plugins.hooks.fire(`filter:${template}.build`, { req: req, res: res, templateData: options });
const buildResult = await plugins.hooks.fire(`filter:${template}.build`, {
req: req,
res: res,
templateData: options,
});
if (res.headersSent) {
return;
}
const templateToRender = buildResult.templateData.templateToRender || template;

const renderResult = await plugins.hooks.fire('filter:middleware.render', { req: req, res: res, templateData: buildResult.templateData });
const renderResult = await plugins.hooks.fire('filter:middleware.render', {
req: req,
res: res,
templateData: buildResult.templateData,
});
if (res.headersSent) {
return;
}
Expand Down

0 comments on commit d61b021

Please sign in to comment.