fix: error handling with POST /api/v1/users

NodeBB · Oct 8, 2020 · d8879d2 · d8879d2
1 parent 58043e0
commit d8879d2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/public/src/admin/manage/users.js b/public/src/admin/manage/users.js
@@ -359,9 +359,8 @@ define('admin/manage/users', ['translator', 'benchpress', 'autocomplete'], funct
 					ajaxify.refresh();
 				});
 				app.alertSuccess('[[admin/manage/users:alerts.create-success]]');
-			}).fail(function () {
-				console.log(arguments);
-				// return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + err.message + ']]').removeClass('hide');
+			}).fail(function (ev) {
+				return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + ev.responseJSON.status.message + ']]').removeClass('d-none').addClass('d-block');
 			});
 		}
 

diff --git a/src/routes/write/users.js b/src/routes/write/users.js
@@ -16,8 +16,12 @@ module.exports = function () {
 	var app = require('express').Router();
 
 	app.post('/', middleware.checkRequired.bind(null, ['username']), middleware.authenticate, middleware.isAdmin, async (req, res) => {
-		const uid = await users.create(req.body);
-		helpers.formatApiResponse(200, res, await users.getUserData(uid));
+		try {
+			const uid = await users.create(req.body);
+			helpers.formatApiResponse(200, res, await users.getUserData(uid));
+		} catch (err) {
+			helpers.formatApiResponse(400, res, err);
+		}
 	});
 
 	// 	app.route('/:uid')

diff --git a/src/views/admin/partials/create_user_modal.tpl b/src/views/admin/partials/create_user_modal.tpl
@@ -1,4 +1,4 @@
-<div class="alert alert-danger hide" id="create-modal-error"></div>
+<div class="alert alert-danger d-none" id="create-modal-error"></div>
 <form>
 	<div class="form-group">
 		<label for="group-name">[[admin/manage/users:create.username]]</label>