refactor: pass only needed data

NodeBB · Jul 30, 2020 · f1974fb · f1974fb
1 parent 9f346c5
commit f1974fb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/groups/search.js b/src/groups/search.js
@@ -58,7 +58,6 @@ module.exports = function (Groups) {
 			...data,
 			paginate: false,
 			hardCap: -1,
-			groupName: data.groupName,
 		});
 
 		const uids = results.users.map(user => user && user.uid);

diff --git a/src/socket.io/groups.js b/src/socket.io/groups.js
@@ -326,7 +326,6 @@ SocketGroups.loadMore = async (socket, data) => {
 };
 
 SocketGroups.searchMembers = async (socket, data) => {
-	data.uid = socket.uid;
 	const [isOwner, isMember, isAdmin] = await Promise.all([
 		groups.ownership.isOwner(socket.uid, data.groupName),
 		groups.isMember(socket.uid, data.groupName),
@@ -335,7 +334,11 @@ SocketGroups.searchMembers = async (socket, data) => {
 	if (!isOwner && !isMember && !isAdmin) {
 		throw new Error('[[error:no-privileges]]');
 	}
-	return await groups.searchMembers(data);
+	return await groups.searchMembers({
+		uid: socket.uid,
+		query: data.query,
+		groupName: data.groupName,
+	});
 };
 
 SocketGroups.loadMoreMembers = async (socket, data) => {