feat: remove app.isConnected, use socket.connected

NodeBB · Sep 7, 2020 · fddeb5c · fddeb5c
1 parent 33c1bd5
commit fddeb5c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/public/src/admin/dashboard.js b/public/src/admin/dashboard.js
@@ -556,7 +556,7 @@ define('admin/dashboard', ['semver', 'Chart', 'translator', 'benchpress'], funct
 		clearInterval(intervals.graphs);
 
 		intervals.rooms = setInterval(function () {
-			if (app.isFocused && app.isConnected) {
+			if (app.isFocused && socket.connected) {
 				socket.emit('admin.rooms.getAll', Admin.updateRoomUsage);
 			}
 		}, realtime ? DEFAULTS.realtimeInterval : DEFAULTS.roomInterval);

diff --git a/public/src/sockets.js b/public/src/sockets.js
@@ -3,7 +3,6 @@
 
 app = window.app || {};
 socket = window.socket;
-app.isConnected = false;
 
 (function () {
 	var reconnecting = false;
@@ -76,8 +75,6 @@ app.isConnected = false;
 	}
 
 	function onConnect() {
-		app.isConnected = true;
-
 		if (!reconnecting) {
 			app.showMessages();
 			$(window).trigger('action:connected');
@@ -155,7 +152,6 @@ app.isConnected = false;
 
 	function onDisconnect() {
 		$(window).trigger('action:disconnected');
-		app.isConnected = false;
 	}
 
 	function onEventBanned(data) {