Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto scroll to first unread post #1064

Closed
bdharrington7 opened this issue Feb 20, 2014 · 10 comments
Closed

Auto scroll to first unread post #1064

bdharrington7 opened this issue Feb 20, 2014 · 10 comments

Comments

@bdharrington7
Copy link
Contributor

... or, start loading from first unread. In most forums, threads tend to get very long, so not having to scroll through all the posts you have read (for the 10th time) would be extremely user friendly

@cnvo
Copy link
Contributor

cnvo commented Feb 20, 2014

Sounds good and would be UX friendly as well in most cases so I agree with
this. Posts that have been seen before or scrolled through verses posts you
haven't seen it should "intelligently" scroll to the first unread post - so
this makes perfect sense here.

Not sure on a priority level for this here - if at all, but hopefully it would be considered.

On Wed, Feb 19, 2014 at 11:34 PM, Brian notifications@github.com wrote:

... or, start loading from first unread. In most forums, threads tend to
get very long, so not having to scroll through all the posts you have read
(for the 10th time) would be extremely user friendly


Reply to this email directly or view it on GitHubhttps://github.com//issues/1064
.

@psychobunny
Copy link
Contributor

@barisusakli recently pushed a pretty cool update for reverse-infinite-scrolling a few days ago, clear cache and check this link out:

http://community.nodebb.org/topic/302/the-unlimited-thread#5723

closing - but pls re-open if I misinterpreted or this feature doesn't meet expectations :)

@bdharrington7
Copy link
Contributor Author

Cool! Actually I was thinking of suggesting that "back loading" feature, where if you scroll up, it will load comments from above, but thought that this was enough for one issue.
I think the issue still stands though... say you click on "unread" in the menu bar. You'll see topics that have unread posts, but you have definitely seen everything up until then, but when you click on it, it takes you to the first post.
I suppose the feature we're asking for could be implemented by keeping track of the last read post per thread by username? and then render links like the above one for the thread titles?

@psychobunny
Copy link
Contributor

We actually do keep track of the last post you visited (I hope! Maybe your browser is messing up on us!)

Let's give it a shot. Visit this link first,
http://community.nodebb.org/topic/302/the-unlimited-thread#5723

and then close the tab and then visit this link:
http://community.nodebb.org/topic/302/the-unlimited-thread

if all goes well, you should be forwarded to post id 5723, because this is the last post NodeBB saw you scroll to :)

@bdharrington7
Copy link
Contributor Author

Ok, so it looks like it kinda works... but kind of in a different way; I
found that it would remember your spot on the thread if you navigate away
(i.e. clicking on the profile of the last user on the thread, then coming
back to the thread), but if I scrolled up to change back to the category,
it would remember that I stopped at the beginning and then take me back
there when I return to the thread...
Also this doesn't seem to be tied to your account, more to the browser. I
scrolled to the bottom of the Plugin Ideas thread, logged out of chrome
canary, logged in on firefox, and then went back to the thread, and was
taken to the beginning again.

On Wed, Feb 19, 2014 at 11:18 PM, psychobunny notifications@github.comwrote:

We actually do keep track of your latest posts (I hope! Maybe your browser
is messing up on us!)

Let's give it a shot. Visit this link first,
http://community.nodebb.org/topic/302/the-unlimited-thread#5723

and then close the tab and then visit this link:
http://community.nodebb.org/topic/302/the-unlimited-thread

if all goes well, you should be forwarded to post id 5723, because this is
the last post NodeBB saw you scroll to :)

Reply to this email directly or view it on GitHubhttps://github.com//issues/1064#issuecomment-35594961
.

-Brian

@psychobunny
Copy link
Contributor

Also this doesn't seem to be tied to your account, more to the browser.

Yup, definitely browser. uses LocalStorage. Plus side is that it doesn't use any unnecessary DB space, but on the other hand I can see someone QQ'ing about reading something on their desktop and not being able to continue on their mobile. @barisusakli what do you think?

but if I scrolled up to change back to the category, it would remember that I stopped at the beginning and then take me back there when I return to the thread...

haha I guess the code is being "too smart". Maybe it should just remember the most recent post you've saw as opposed to the last post you saw. Thanks for the comments btw @bdharrington7

@bdharrington7
Copy link
Contributor Author

Yeah no problem, just trying to help :) fwiw would it really be that much more space in the DB? The number of entries to store that information (position per user per thread) would only be users*threads and that's only if every user reads every thread... It would typically be much less. I don't know how optimized redis is but if each entry was a couple bytes, you would use ~2mb for 1000 users reading all 1000 threads.
Again I'm not the expert, but I know redis is all in memory so entries shouldn't be stored carelessly

-Brian

On Feb 19, 2014, at 11:55 PM, psychobunny notifications@github.com wrote:

Also this doesn't seem to be tied to your account, more to the browser.

Yup, definitely browser. uses LocalStorage. Plus side is that it doesn't use any unnecessary DB space, but on the other hand I can see someone QQ'ing about reading something on their desktop and not continuing on their mobile. @barisusakli what do you think?

but if I scrolled up to change back to the category, it would remember that I stopped at the beginning and then take me back there when I return to the thread...

haha I guess the code is being "too smart". Maybe it should just remember the most recent post you've saw as opposed to the last post you saw. Thanks for the comments btw @bdharrington7


Reply to this email directly or view it on GitHub.

@psychobunny
Copy link
Contributor

No no I agree with you 100%, the convinience of being able to continue a thread on a diff device far outweighs whatever extra data we store in DB. Paging the expert on this one @barisusakli

@psychobunny
Copy link
Contributor

ah, we can also throw an expiry on the key as well, so lets say after a month, we can expire the key and forget about it (at that point, who cares anymore)

@bdharrington7
Copy link
Contributor Author

That's a good idea, but it would be nice to have that as an option to
toggle in the ACP

On Thu, Feb 20, 2014 at 12:48 AM, psychobunny notifications@github.comwrote:

ah, we can also throw an expiry on the key as well, so lets say after a
month, we can expire the key and forget about it (at that point, who cares
anymore)

Reply to this email directly or view it on GitHubhttps://github.com//issues/1064#issuecomment-35599542
.

-Brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants