upgrading from 2.3.x to 2.8.x errors on first try

[barisusakli]

Error occurred during upgrade: TypeError: maxAge must be a number
    at LRUCache.set (/home/saas/nodebb/node_modules/lru-cache/index.js:157:13)
    at Object.cache.set (/home/saas/nodebb/src/cache/lru.js:68:12)
    at /home/saas/nodebb/src/database/mongo/hash.js:138:10
    at Array.forEach (<anonymous>)
    at module.getObjectsFields (/home/saas/nodebb/src/database/mongo/hash.js:136:16)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async module.getObjects (/home/saas/nodebb/src/database/mongo/hash.js:92:10)
    at async module.getObject (/home/saas/nodebb/src/database/mongo/hash.js:87:16)
    at async Configs.getFields (/home/saas/nodebb/src/meta/configs.js:111:12)
    at async Configs.list (/home/saas/nodebb/src/meta/configs.js:98:9)

Running it again works fine, possibly due to lru-cache depency getting upgraded during ./nodebb upgrade but the old one is still being used since its already loaded.

[barisusakli]

This was caused by lru-cache@6.0.0 being loaded by semver before the upgrade script had a chance to upgrade the dependencies.

[julianlam]

Thanks for figuring it out 😄