fix: closes #11173, clear require cache if wrong dependency is installed

NodeBB · Jan 18, 2023 · 747cb1f · 747cb1f
1 parent 48c9f44
commit 747cb1f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/cli/index.js b/src/cli/index.js
@@ -32,6 +32,12 @@ try {
 		if (!semver.satisfies(version, defaultPackage.dependencies[packageName])) {
 			const e = new TypeError(`Incorrect dependency version: ${packageName}`);
 			e.code = 'DEP_WRONG_VERSION';
+			// delete the module from require cache so it doesn't break rest of the upgrade
+			// https://github.com/NodeBB/NodeBB/issues/11173
+			const resolvedModule = require.resolve(packageName);
+			if (require.cache[resolvedModule]) {
+				delete require.cache[resolvedModule];
+			}
 			throw e;
 		}
 	};