New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepSessionInfo is always true #11254

Closed

nesro opened this issue Feb 2, 2023 · 0 comments

Labels

bug

Contributor

nesro commented Feb 2, 2023 •

edited

Hi all,
this commit 65b3996 contains a small error that reroll part of locals object is missing in the check.

It's used here: https://github.com/julianlam/nodebb-plugin-session-sharing/blob/master/library.js#L427 (more info here 816856b0 )

EDIT: hmm, as I'm testing it, I'm not sure if it actually works as expected. I will do some more testing and get back here with more info

The text was updated successfully, but these errors were encountered:

nesro added the bug label

nesro added a commit to nesro/NodeBB that referenced this issue


          fix: NodeBB#11254, return check for reroll property

2e45b74

julianlam closed this as completed in

202378b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment