Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderator's own queued posts show incorrect action buttons #11362

Closed
julianlam opened this issue Mar 16, 2023 · 2 comments
Closed

Moderator's own queued posts show incorrect action buttons #11362

julianlam opened this issue Mar 16, 2023 · 2 comments
Assignees
@julianlam
Labels
breaking change (plugins) bug
Milestone
3.0.0

Comments

@julianlam
Copy link
Member

Kind of an edge case, yes 馃槅

If a moderator has one of their posts queued, it shows up in the post queue, but the buttons show accept/reject/etc.
@julianlam julianlam added the bug label Mar 16, 2023
@julianlam julianlam self-assigned this Mar 16, 2023
@julianlam julianlam added this to the 3.0.0 milestone Mar 16, 2023
@julianlam
Copy link
Member Author

canAccept is at root level and applies to all queued posts. Needs refactor so it is inside posts

@julianlam
Copy link
Member Author

julianlam commented Mar 16, 2023 •
edited

馃毃 Breaking change

  • canAccept is no longer at root level, it will be inside each individual post queue object
  • If you've a theme that overrides post-queue.tpl, you'll need to update it. Chances are you don't or if you do, it's just a direct copy of the one in src/views and can be deleted.

julianlam added a commit that referenced this issue Mar 17, 2023
@julianlam
fix: #11362, regular mods are also subject to post queue [breaking]
2ce9874
julianlam added a commit that referenced this issue Mar 17, 2023
@julianlam
fix: #11362, regular mods are also subject to post queue [breaking]
5abf6f9
julianlam added a commit that referenced this issue Mar 17, 2023
@julianlam
fix: #11362, regular mods are also subject to post queue [breaking]
c843984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
breaking change (plugins) bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@julianlam @barisusakli