Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a unique id for all ActivityPub server-to-server events #12483

Open
julianlam opened this issue Apr 8, 2024 · 2 comments
Open

Send a unique id for all ActivityPub server-to-server events #12483

julianlam opened this issue Apr 8, 2024 · 2 comments
Assignees
@oplik0

Comments

@julianlam
Copy link
Member

e.g. Create(Note) contains two ids, one for the Create, and another for the Note. This issue pertains to the former.

Apparently activity IDs could be used as part of an Undo call shrug

Further research needed.
@julianlam julianlam changed the title Send a unique id for all events Send a unique id for all ActivityPub server-to-server events Apr 8, 2024
@oplik0 oplik0 mentioned this issue Apr 9, 2024
Closed
@oplik0
Copy link
Contributor

oplik0 commented Apr 9, 2024

Status update: now Create(Note), Update(Note), Follow and Undo(Follow) have ids.

@julianlam
Copy link
Member Author

silverpill notified me that our Like activities are also missing an id, which is necessary as some implementations use the id to handle undos.

oplik0 added a commit that referenced this issue Apr 22, 2024
@oplik0
feat: add id to Like
ab055a7 
part of #12483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oplik0 oplik0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianlam @oplik0