-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer should serve a mobile template based on viewport detection #1657
Comments
To be honest, the problem stems from the fact that the composer is designed to be viewed on a desktop. Many of the considerations we made are no longer factors on mobile. For example, the composer is minimizable, but the entire task bar itself is hidden on mobile. |
Sounds good to me! Ok, so I've been all in for the mobile viewport detection or more so, using a library such as Modernizer to detect client browsers. |
Seems like a step in a good direction. Why not use a sliding transition to
|
On mobile? Hahah that would be so app like... I'd be open for it but the simpler the better. |
Mainly because mobile users are used to the full screen composers used for
|
just a copy of composer.tpl - baby steps.
Maybe this is a bit off the direction of this particular issue, but can we get a composer with live preview instead of having to click back and forth to see if something is formatted the right way? Something like an enhanced WYSIWYG? I don't remember if this was brought up. I remember talking about some type of "Xen" or "Fullscreen" mode, but thats besides the point. |
To add to the mobile discussion topic, my own suggestions:
Objective is to gain as much real estate as possible and provide large easy to press inputs. Mobile specific theme should also exclude any mouse over specific functionality (like quote/reply), larger fonts should be reconsidered at the expense of truncation. |
It's taken me until now to realise it's almost impossible to post on an iPad. 😆 Headers over the text bar etc. I'd +1 an app style mobile view. |
Can you post a screen grab of how it looks on the ipad? |
@barisusakli Actually, we did get an informal go-ahead from one of our previous clients to use their BrowserStack login, so please do go ahead and take advantage of that 😄 |
I think we can all agree that using NodeBB on a phone is great for viewing, but not so great for posting.
Part of that is because we're trying to do too much. The composer is a single responsive template that is loaded for all devices, even small ones. While for the rest of NodeBB, this works fine (thanks to bootstrap and other responsive work we've done), it gets really tough to work with when the keyboard is up, thereby severely diminishing the available vertical real-estate we have to work with.
So it seems the best course of action would be to split the templates up into two, the current existing one stays the same, and would be used for desktops. A second one,
composer_mobile
, would be for... mobile.We could use viewport size detection in this line of code (perhaps using a new utils function?) and serve the mobile template instead.
RFC for comments/mockups (@cnvo?)/etc
The text was updated successfully, but these errors were encountered: