Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split upload directory into separate folders #2157

Closed
cnvo opened this issue Sep 26, 2014 · 8 comments
Closed

Split upload directory into separate folders #2157

cnvo opened this issue Sep 26, 2014 · 8 comments
Milestone

Comments

@cnvo
Copy link
Contributor

cnvo commented Sep 26, 2014

I've been thinking that we should clean up the directories a bit further than just the naming extensions e.g. *-profileimg.* to give some type of organization and differentiation between the images and files within the /public/uploads directory into three separate folders.

/public/uploads/profile ...for user profiles.
/public/uploads/category ...for the category images.
/public/uploads/files ...for the uploaded files via topic/post images and files.

@julianlam
Copy link
Member

Funny how things like that just happen to collect more and more over time.

A bunch of different projects I have worked on all suffered from this... /images folder, always a dumping ground with no structure whatsoever 😆

@psychobunny
Copy link
Contributor

Ah okay now we know who to blame :D on the record
On 25 Sep 2014 23:47, "Julian Lam" notifications@github.com wrote:

Funny how things like that just happen to collect more and more over time.

A bunch of different projects I have worked on all suffered from this...
/images folder, always a dumping ground with no structure whatsoever [image:
😆]


Reply to this email directly or view it on GitHub
#2157 (comment).

@psychobunny
Copy link
Contributor

potentially related issues that might be better off solved all at once:

#1509
#725

@barisusakli
Copy link
Member

Who wants to write the upgrade script for this 😆

@barisusakli barisusakli added this to the 0.5.2 milestone Oct 8, 2014
@baerrus
Copy link

baerrus commented Oct 29, 2014

Folks, this feature needs a bit of polishing. - A configurable root path so the images can be kept outside nodebb tree. I believe there is a good rationale for that. I keep redis dump on a separate volume which gets backed up daily. The images are really part of user generated content and should be located somewhere next to redis to get the benefit of backup. Currently that is not possible.

@julianlam
Copy link
Member

@baerrus Is backing up public/uploads not enough? That folder contains only user-uploaded assets.

Edit: Oh, I see what you mean, you want it on a different partition altogether. Perhaps a --assets-dir flag...

@baerrus
Copy link

baerrus commented Oct 29, 2014

Yes, --asset-dir flag and ability to configure during "./nodebb setup" would fit the bill, I think

@julianlam
Copy link
Member

Superceded by #2318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants