Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log IP information for events. #2518

Closed
dwendt opened this issue Dec 11, 2014 · 3 comments
Closed

Log IP information for events. #2518

dwendt opened this issue Dec 11, 2014 · 3 comments
Assignees
Milestone

Comments

@dwendt
Copy link
Contributor

dwendt commented Dec 11, 2014

https://github.com/NodeBB/NodeBB/blob/master/src/events.js

To make events more useful, IP should be logged for the majority of these. Ideally, it would be any event directly associated with a user/socket/request.

@barisusakli barisusakli added this to the 0.6.1 milestone Dec 22, 2014
@barisusakli barisusakli self-assigned this Dec 22, 2014
@julianlam
Copy link
Member

@barisusakli events.js seems to be an abstraction lib exposing user-friendly methods to print to file, but should we save the audit log to the database instead?

Possibly an unnecessary complication, but it might be easier to do events.log(req, socket, comment, callback) instead, and pass in either req or socket, and have the lib tease out the relevant information...

@barisusakli
Copy link
Member

I agree might be better to save in db or a central place, right now events are logged on separate machines if you scale horizontally.

@julianlam
Copy link
Member

👍 Ok, seems a good low priority item for 0.6.1+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants