Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare disney for merging #2860

Closed
1 of 4 tasks
julianlam opened this issue Mar 13, 2015 · 2 comments
Closed
1 of 4 tasks

Prepare disney for merging #2860

julianlam opened this issue Mar 13, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@julianlam
Copy link
Member

The majority of the issues have been fixed, and runs well on latest master code. 馃憦

Here are some bugs I ran into, which may or may not be applicable:

  • This pull request
  • Typing Home and End moves the paginator up and down as expected, but the label does not change (e.g. from the top of the page, hit End, and the label is now at the bottom, but still says "1 of 61"
  • Home/End/PgUp/PgDn behaviour is on and off... doesn't work on cold load, but starts working after the scrollbar is clicked (and another "page" in the topic is loaded)

... and this one's just a nitpick:

  • Given the nature of the scrollbar, I expect Home to bring me to the top couple posts, and End to bring me to the last couple. Instead right now, it is:
    • Home goes to top of page, and loads more posts if applicable. So if you were viewing 51-61 before, now you're viewing post indices 1, 40-50
    • End takes you to the bottom, and the infinite loader triggers
    • Perhaps it would be easier to hijack the Home and End keys to load first and last page, respectively.
@psychobunny
Copy link
Contributor

Thanks for this, going through it and this is what I got so far

  1. Reverse infinite scrolling is broken 馃憥

Home / End might be broken because of above (pretty sure that used to work).

  1. Infinite scrolling on category both ways is broken

btw, didn't get either of the errors you got for tjs on FF but I'll merge it anyways (and reassign all bugs to you 馃檳)

@julianlam
Copy link
Member Author

hahah yeah, it's a chrome only bug since chrome is stricter with object cloning I guess, as functions can't really be stringified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants