Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add the option to disable Gravatar #3103

Closed
niklas-heer opened this issue Apr 29, 2015 · 13 comments
Closed

Proposal: Add the option to disable Gravatar #3103

niklas-heer opened this issue Apr 29, 2015 · 13 comments
Assignees
Milestone

Comments

@niklas-heer
Copy link

Sorry if I am bordering you guys, but I have a forum with really privacy-focused people so I researched a lot of stuff lately.

The problem with Gravatar is that according to this discussion the Gravatar service was only created to collect data and monetize it. Therefor I would like to have an option to disable Gravatar in the ACP, as discussed a while ago here.

@julianlam
Copy link
Member

was only created to collect data and monetize it

I wouldn't go so far as to assume that was the only reason for Gravatar's inception. You'll have to admit that it does come in handy for quick avatar creation/reference.

That said, I do eventually want to strip out Gravatar into a plugin, so we'll use this as the issue to track that eventual change.

@julianlam julianlam self-assigned this Apr 29, 2015
@julianlam julianlam added this to the 1.0.0 milestone Apr 29, 2015
@niklas-heer
Copy link
Author

I wouldn't go so far as to assume that was the only reason for Gravatar's inception. You'll have to admit that it does come in handy for quick avatar creation/reference.

Sure it is really handy, but it also comes with hidden costs and these costs imoh are not worth the thing you're getting.
So I'm very glad to hear these news, thanks! :)

@phoenixlzx
Copy link

+1 on this, and in some area gravatar may stuck on loading.

@julianlam julianlam modified the milestones: 0.7.1, 0.7.2 Jul 17, 2015
@julianlam julianlam modified the milestones: 0.7.2, 0.7.3 Jul 28, 2015
@julianlam julianlam modified the milestones: 0.7.3, 0.7.4 Aug 18, 2015
@barisusakli barisusakli modified the milestones: 0.8.0, 0.8.1 Aug 27, 2015
@julianlam julianlam modified the milestones: 0.8.1, 0.8.2 Sep 1, 2015
@NijiharaTsubasa
Copy link

Please, we need a way to disable gravatar.
We are hosting a forum with nodebb in China. China GFWed(blocked) gravatar.
And as a result it stuck on loadinguntil connection timeout, even not displaying the default one set in admin panel.

@julianlam julianlam modified the milestones: 0.8.2, 0.8.3 Sep 16, 2015
@julianlam julianlam modified the milestones: 0.8.3, 0.8.2 Sep 16, 2015
@Watomsk
Copy link

Watomsk commented Oct 21, 2015

I concur with Phoenixlzx. Gravatar sometimes gets stuck on loading in my forums. I really wish we could disable it.

@robotanarchy
Copy link

I'd also like to have an option for disabling gravatar.

@julianlam
Copy link
Member

We have a working solution although it is currently not compatible with all
browsers.

Still investigating alternatives....

On Wed, 21 Oct 2015 12:44 robotanarchy notifications@github.com wrote:

I'd also like to have an option for disabling gravatar.


Reply to this email directly or view it on GitHub
#3103 (comment).

@robotanarchy
Copy link

@julianlam: I don't quite understand what you need to investigate or check against browsers there.

When Gravatar is disabled, I'd expect a default picture, something like that (random google images search...): http://www.keralabjp.org/images/No_Image.jpg

Uploading custom user pictures already works anyway.

If you want to make it extra nice, give the admin the ability to upload a default picture.

So what exactly is the problem?

@julianlam
Copy link
Member

The alternative was to use a letter with random background, constructed via
css.

Works great on Chrome, doesn't work at all. on Firefox.

Version 1 of this worked quite well across browsers, but was quite a bit of
work to convert for existing themes, hence the search for a better
solution.

On Wed, 21 Oct 2015 23:52 robotanarchy notifications@github.com wrote:

@julianlam https://github.com/julianlam: I don't quite understand what
you need to investigate or check against browsers there.

When Gravatar is disabled, I'd expect a default picture, something like
that (random google images search...):
http://www.keralabjp.org/images/No_Image.jpg

Uploading custom user pictures already works anyway.

If you want to make it extra nice, give the admin the ability to upload a
default picture.

So what exactly is the problem?


Reply to this email directly or view it on GitHub
#3103 (comment).

@robotanarchy
Copy link

How about generating these images on the server side (maybe with a cache?) or at least implementing the simple solution I've described until the better version is ready?

@julianlam
Copy link
Member

They're not images.

On Thu, 22 Oct 2015 13:21 robotanarchy notifications@github.com wrote:

How about generating these images on the server side (maybe with a cache?)
or at least implementing the simple solution I've described until the
better version is ready?


Reply to this email directly or view it on GitHub
#3103 (comment).

@robotanarchy
Copy link

What I ment is: generate it on the server side, then cache it as image (the identicon nodejs library can do that).

However, if you want to do it client-side only, what about Jdenticon for example? It works on the following browsers:

Internet Explorer 9 and later
Chrome 7 and later
Firefox 4 and later
Opera 11 and later
Safari 5 and later

EDIT: I just saw that Jdenticon also works with nodejs, if desired.

@julianlam
Copy link
Member

User Icons merged into master now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants