Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs missing from various pages #3475

Closed
henrywright opened this issue Aug 24, 2015 · 1 comment
Closed

Breadcrumbs missing from various pages #3475

henrywright opened this issue Aug 24, 2015 · 1 comment
Assignees
Milestone

Comments

@henrywright
Copy link
Contributor

I'm not sure if this is a Persona-related issue (or even if it's an issue at all) but it seems some pages don't have breadcrumbs yet some do. It would be nice to keep the breadcrumb trail consistent across all pages.

  • example.com/users
  • example.com/users/online
  • example.com/users/latest
  • example.com/users/sort-posts
  • example.com/users/sort-reputation
  • example.com/users/map
  • example.com/users/search
  • example.com/notifications
  • example.com/chats
  • example.com/chats/username
  • example.com/user/username
  • example.com/user/username/edit
  • example.com/user/username/settings
  • example.com/user/username/following
  • example.com/user/username/followers
  • example.com/user/username/topics
  • example.com/user/username/posts
  • example.com/user/username/groups
  • example.com/user/username/favorites
  • example.com/user/username/watched
  • example.com/categories
  • example.com/unread
  • example.com/groups

I've been through all of the pages that get generated and that should be all of the ones that are missing them.

@julianlam
Copy link
Member

😄 Awesome! Such a nice curated list of pages to add breadcrumbs to 👍

@barisusakli just a note -- I recall being unable to use the account_menu partials in my own plugins, though right now I can't recall why. Maybe it was because it used data that my plugins didn't send, like userslug and uid... maybe they can be accessed in other ways?

@barisusakli barisusakli added this to the 0.8.1 milestone Aug 27, 2015
@julianlam julianlam modified the milestones: 0.8.1, 0.8.2 Sep 1, 2015
barisusakli added a commit that referenced this issue Sep 12, 2015
barisusakli added a commit that referenced this issue Sep 12, 2015
@barisusakli barisusakli self-assigned this Sep 12, 2015
barisusakli added a commit to NodeBB/nodebb-theme-persona that referenced this issue Sep 12, 2015
barisusakli added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants