Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current dockerfile will not be able to pass setup stage #4633

Closed
Haocen opened this issue May 12, 2016 · 5 comments
Closed

Current dockerfile will not be able to pass setup stage #4633

Haocen opened this issue May 12, 2016 · 5 comments

Comments

@Haocen
Copy link

Haocen commented May 12, 2016

Thanks to config.json being reset after each rebuild of container.
Some files, like plugins installed and configuration files should be specified as volume.
Can anybody kindly tell me what files need to be preserved after each restart? Besides config.json?
My temporary solution is to specify the whole /src/usr/app as volume. Really bad practice, lost huge benefit of using docker.

@julianlam
Copy link
Member

@BenLubar?

@BenLubar
Copy link
Contributor

BenLubar commented May 12, 2016

It'd be nice to have the config.json file stored in some subdirectory that would be able to be persisted. Additionally, having a list of installed plugins in there would be nice for switching containers without having to redo everything.

Right now, I have echo 1 > pidfile && exec node loader.js as my Docker startup command for the NodeBB containers I'm running and they aren't remade for each update (I'd rather do it the Docker way, but this works).

BenLubar added a commit to BenLubar/NodeBB that referenced this issue May 12, 2016
…ume. also automatically run the upgrade script at container startup. update NodeBB#4633
@BenLubar
Copy link
Contributor

BenLubar@c76a139 solves the config file part, but not the plugins yet. Ideally the plugins should be done in a way that lets plugins that aren't from NPM work.

@BenLubar
Copy link
Contributor

BenLubar commented Jun 1, 2016

@Haocen In the last week or so, we've been using https://github.com/boomzillawtf/tdwtf to manage our Docker container. You could probably do something similar for yours. Basically, we no longer use NodeBB's plugin installation/update buttons, and updates are fully installed before the forum switches over to the new instance.

@Haocen
Copy link
Author

Haocen commented Jun 1, 2016

Sounds like a solution, thank you for letting me know.

@Haocen Haocen closed this as completed Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants