Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket.io getPost not sanitized (IP address included for non-admins) #4810

Closed
BenLubar opened this issue Jun 30, 2016 · 1 comment
Closed

socket.io getPost not sanitized (IP address included for non-admins) #4810

BenLubar opened this issue Jun 30, 2016 · 1 comment
Assignees
@barisusakli
Labels
bug
Milestone
1.1.0

Comments

@BenLubar
Copy link
Contributor

Screenshot from a non-admin user:

The JSON returned by the REST API does not include the IP address.
@BenLubar
Copy link
Contributor Author

@barisusakli https://github.com/NodeBB/NodeBB/blob/v1.0.3/src/topics/posts.js#L140 isn't called by https://github.com/NodeBB/NodeBB/blob/v1.0.3/src/controllers/api.js#L141

@barisusakli barisusakli self-assigned this Jul 1, 2016
@barisusakli barisusakli added this to the 1.1.0 milestone Jul 1, 2016
@barisusakli barisusakli added the bug label Jul 1, 2016
BenLubar added a commit to boomzillawtf/tdwtf that referenced this issue Jul 1, 2016
@BenLubar
- Fixed: socket.io getPost not sanitized (IP address included for non…
23ffe0e 
…-admins) <NodeBB/NodeBB#4810>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barisusakli barisusakli

Labels
bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@barisusakli @BenLubar