Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for custom homepage route in profile settings #4815

Closed
joetm opened this issue Jul 3, 2016 · 1 comment
Closed

Validation for custom homepage route in profile settings #4815

joetm opened this issue Jul 3, 2016 · 1 comment
Assignees
@barisusakli
Labels
enhancement
Milestone
1.1.1

Comments

@joetm
Copy link

joetm commented Jul 3, 2016

Users can enter a "Custom Homepage Route" in their profile settings.
If you leave this blank or fill in a non-existing route, the member will get to see an error on the homepage:

Not Found
You seem to have stumbled upon a page that does not exist. Return to the home page.

This will produce unnecessary support questions from members who think their homepage is broken.
I suggest to validate the entered home page route before saving it.
@digitalLumberjack
Copy link

I just had the same issue, just saving the profile page for the first time, and now my home page is a 404 :)

@barisusakli barisusakli added this to the 1.1.1 milestone Jul 15, 2016
@barisusakli barisusakli self-assigned this Jul 15, 2016
BenLubar added a commit to boomzillawtf/tdwtf that referenced this issue Jul 15, 2016
@BenLubar
- convert post parent button to a link <NodeBB/NodeBB#4853> <NodeBB/n…
1f02ac6 
…odebb-theme-persona#300>

- fixed homePageRoute being set to `custom` if the field was left empty <NodeBB/NodeBB@c042d16>
- validation for custom homepage route in profile settings <NodeBB/NodeBB#4815>
- `/unread` is now one of the default homepage route choices <NodeBB/NodeBB@390ad35>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barisusakli barisusakli

Labels
enhancement
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
3 participants
@digitalLumberjack @barisusakli @joetm