Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User registration failure with TOS enabled. #4883

Closed
ghost opened this issue Jul 24, 2016 · 3 comments
Closed

User registration failure with TOS enabled. #4883

ghost opened this issue Jul 24, 2016 · 3 comments
Assignees
@julianlam
Labels
bug regression
Milestone
1.1.1

Comments

@ghost
Copy link

ghost commented Jul 24, 2016

Nodebb version 1.1.0 and 1.1.1-auto

User registration failure with TOS enabled. The user remains stuck to pending.

To replicate the problem:

  • Enable a TOS on /admin/settings/user
  • Create a user with a local registration

Regards
Vincenzo Tilotta
@barisusakli barisusakli added this to the 1.1.1 milestone Jul 25, 2016
@barisusakli
Copy link
Member

Seems like the redirect to /register/complete doesn't work.

@julianlam
Copy link
Member

Thanks @barisusakli

julianlam added a commit that referenced this issue Jul 25, 2016
@julianlam
Revert "if interstitials don't pass any errors back but some still ex…
4ce8696 
…ist, redirect properly"

This reverts commit 98368bb, but fixes
issue #4883
@julianlam
Copy link
Member

Not sure why, but works fine if I revert 98368bb.

BenLubar added a commit to boomzillawtf/tdwtf that referenced this issue Jul 25, 2016
@BenLubar
- filter:group.update <NodeBB/NodeBB#4880>
b50c9c9 
- Fixed: URL at the bottom of [chat] notification emails does not work <NodeBB/NodeBB#4886>
- Fixed: Interpolation does not work in test email <NodeBB/NodeBB#4884>
- Fixed: Invited users in the users groups does not update without a page load. <NodeBB/NodeBB#4881>
- Include topic title in topic/post purge events in ACP <NodeBB/NodeBB#4877>
- [enhancement] "Admin Approval for IPs" registration mode <NodeBB/NodeBB#4882>
- Fixed: User registration failure with TOS enabled <NodeBB/NodeBB#4883>
- better error handling for session revocation if no login session is present <NodeBB/NodeBB#4214>
ralic pushed a commit to ralic/NodeBB that referenced this issue Jul 26, 2016
@julianlam @ralic
Revert "if interstitials don't pass any errors back but some still ex…
2b6ca6b 
…ist, redirect properly"

This reverts commit 98368bb, but fixes
issue NodeBB#4883
@barisusakli barisusakli mentioned this issue Aug 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
bug regression
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@julianlam @barisusakli