New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running an upgrade should also append its output to logs #5584
Comments
@Saksham-1612 Hi! We're always open to contributions. Let me know if you have any questions. |
Is the issue still open? |
If you can fix it, open a pull request 👌 |
By output, do we mean the console.log output? If yes, So is the task about logging them using the winston logger? |
@neha-gunta thanks for the follow up. Currently both the upgrade and regular running of NodeBB call The issue is a little complicated because our current Winston config does not have any settings for file output. If you want to resolve this issue, you would have to fix that config so it outputs to the proper file location for both regular running of NodeBB, and for upgrade scripts... Basically anywhere that calls setupWinston |
There is existing logic that takes stdout and stderr and redirects them to output.log. you would probably want to remove that in favor of the Winston configuration. |
When running
./nodebb upgrade
, the output should also append tologs/output.log
just as it does for./nodebb start
. These logs can be viewed by running./nodebb log
.Good for beginners, feel free to ask here for tips on getting started.
The text was updated successfully, but these errors were encountered: