Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running an upgrade should also append its output to logs #5584

Closed
psychobunny opened this issue Apr 11, 2017 · 6 comments
Closed

Running an upgrade should also append its output to logs #5584

psychobunny opened this issue Apr 11, 2017 · 6 comments

Comments

@psychobunny
Copy link
Contributor

When running ./nodebb upgrade, the output should also append to logs/output.log just as it does for ./nodebb start. These logs can be viewed by running ./nodebb log.

Good for beginners, feel free to ask here for tips on getting started.

@psychobunny psychobunny added this to the 1.5.0 milestone Apr 11, 2017
@barisusakli barisusakli removed this from the 1.5.0 milestone Apr 22, 2017
@pitaj
Copy link
Contributor

pitaj commented Dec 31, 2022

@Saksham-1612 Hi! We're always open to contributions. Let me know if you have any questions.

@NodeBB NodeBB deleted a comment from shadow0500 Jun 9, 2023
@NodeBB NodeBB deleted a comment from shadow0500 Jun 9, 2023
@NodeBB NodeBB deleted a comment from nakulbh Oct 3, 2023
@NodeBB NodeBB deleted a comment from ssy2306 Oct 3, 2023
@NodeBB NodeBB deleted a comment from Noothan-am Oct 3, 2023
@NodeBB NodeBB deleted a comment from Saksham-1612 Oct 3, 2023
@NodeBB NodeBB deleted a comment from mani9896 Oct 3, 2023
@NodeBB NodeBB deleted a comment from asamolion Oct 3, 2023
@neha-gunta
Copy link

Is the issue still open?

@julianlam
Copy link
Member

If you can fix it, open a pull request 👌

@neha-gunta
Copy link

By output, do we mean the console.log output? If yes, So is the task about logging them using the winston logger?
If no, can you please elaborate on the output part. TIA!

@julianlam
Copy link
Member

@neha-gunta thanks for the follow up. Currently both the upgrade and regular running of NodeBB call setupWinston, and all it does is output to the console.

The issue is a little complicated because our current Winston config does not have any settings for file output. If you want to resolve this issue, you would have to fix that config so it outputs to the proper file location for both regular running of NodeBB, and for upgrade scripts... Basically anywhere that calls setupWinston

@julianlam
Copy link
Member

There is existing logic that takes stdout and stderr and redirects them to output.log. you would probably want to remove that in favor of the Winston configuration.

barisusakli added a commit that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants