Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404s for /assets/client-noskin.css and /assets/src/client/404.js #7274

Closed
tom-rade opened this issue Jan 21, 2019 · 8 comments
Closed

404s for /assets/client-noskin.css and /assets/src/client/404.js #7274

tom-rade opened this issue Jan 21, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@tom-rade
Copy link

  • NodeBB version: v1.11.1
  • NodeBB git hash: 4063782
  • Database type: mongo
  • Database version: v4.0.5

Users apparently get 404s for these paths, maybe this is a bug?

/assets/client-noskin.css
/assets/src/client/404.js
@julianlam julianlam self-assigned this Jan 21, 2019
@julianlam julianlam added the bug label Jan 21, 2019
@tom-rade
Copy link
Author

@julianlam Not sure if relevant, but also

/assets/src/client/confirm.js

is 404ed

@julianlam
Copy link
Member

Are you able to reproduce client-noskin.css? I am not, could be that it was fixed already. If the error counter doesn't go up, then it was probably something that happened before but has since been fixed.

@tom-rade
Copy link
Author

@julianlam Thank you! I didn't update when you did the commit. I have no errors now, great!

@tom-rade
Copy link
Author

tom-rade commented Jan 21, 2019

@julianlam Nevermind - I updated and rebuilt NodeBB, and it still appears as a 404:

/assets/client-noskin.css

Please reopen the issue.

@julianlam
Copy link
Member

julianlam commented Jan 21, 2019

Don't know how to trigger it. When I load the site, client.css is requested, not client-noskin.css.

@tom-rade
Copy link
Author

@julianlam /assets/src/client/registerComplete.js For example was definitely fixed. I suppose all /client paths (judging by the commit). But this one is just /assets/client-noskin.css (without /client). Maybe that helps.

I'll try to look into it, currently random users are producing this 404. In a couple of minutes already 5 404s happened.

@julianlam
Copy link
Member

The client js issue was a different bug, so best to open a new one for client-noskin. Are you using a custom theme? It probably needs theme fixed outlined in #7266

@tom-rade
Copy link
Author

@julianlam Found a way to reproduce it. #7276

I'm using the default Persona theme

@julianlam julianlam modified the milestones: 1.12.0, 1.11.2 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants