Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change privileges behaviour to commit on save button click, instead of save-on-change #8537

Closed
julianlam opened this issue Jul 31, 2020 · 0 comments
Closed

Change privileges behaviour to commit on save button click, instead of save-on-change #8537

julianlam opened this issue Jul 31, 2020 · 0 comments
Assignees
@julianlam
Labels
enhancement
Milestone
1.15.0

Comments

@julianlam
Copy link
Member

... should allow for easier changes without the danger of committing the change immediately upon click of the checkbox.
@julianlam julianlam added this to the 1.15.0 milestone Jul 31, 2020
@julianlam julianlam self-assigned this Jul 31, 2020
julianlam added a commit that referenced this issue Jul 31, 2020
@julianlam
feat: privileges save button, #8537, WIP
eabc9ed
julianlam added a commit that referenced this issue Aug 1, 2020
@julianlam
feat: closes #8537 privilege changes commit on save
9fb22b7 
- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
enhancement
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
1 participant
@julianlam