Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies in public/vendor are outdated #8734

Closed
20 of 23 tasks
barisusakli opened this issue Oct 9, 2020 · 0 comments
Closed
20 of 23 tasks

dependencies in public/vendor are outdated #8734

barisusakli opened this issue Oct 9, 2020 · 0 comments
Assignees
@barisusakli
Labels
breaking change (plugins) enhancement
Milestone
1.15.0

Comments

@barisusakli
Copy link
Member

barisusakli commented Oct 9, 2020 •
edited

Since they are not in package.json they are not tracked
https://github.com/NodeBB/NodeBB/tree/master/public/vendor

  • bootbox
  • colorpicker
  • fontawesome (already using latest 4.7.0, Update FontAwesome to 4.7.0 #5371)
  • jquery
    • bootstrap-tagsinput
    • css/smoothness
    • deserialize
    • draggable-background (no npm module, already using latest 1.2.4)
    • event
    • js/jquery-ui.js
    • js/jquery.form.min.js
    • serializeObject
    • sortable
    • textcomplete
    • timeago
  • mdl (css only)
  • requirejs
  • nprogress
  • visibilityjs
  • tinycon
  • slideout
  • semver-browser
  • xregexp (moved to package.json will be removed from public/vendor in 1.16.0 with utils.slugify deprecation)
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734 move r.js to package.json
aa08f88
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734, move nprogress to package.json
a46cbb6
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734, move visibilityjs to package.json
43589a7
barisusakli added a commit to NodeBB/nodebb-theme-persona that referenced this issue Oct 9, 2020
@barisusakli
https://github.com/NodeBB/NodeBB/issues/8734
144a5dc
@barisusakli barisusakli reopened this Oct 9, 2020
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734, move tinycon to package.json
9c157de
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734, move slideout to package.json
2c1897b
barisusakli added a commit that referenced this issue Oct 9, 2020
@barisusakli
feat: #8734, remove semver.browser
ae3a231 
use compare-versions as a module
@barisusakli barisusakli pinned this issue Oct 9, 2020
@barisusakli barisusakli self-assigned this Oct 9, 2020
barisusakli added a commit that referenced this issue Oct 10, 2020
@barisusakli
feat: #8734, jquery-ui, jquery-form, timeago
9ef44b9 
get rid of forum/footer.js move that code to app.js & wait for app to load before calling ajaxify.end
make sockets.js a requirejs module
move jquery-ui to node_modules and load via requirejs
move jquery-form to node_modules and load via requirejs
move timeago to node_modules and load via requirejs
only include the css for needed jquery-ui widgets
@barisusakli barisusakli added this to the 1.15.0 milestone Oct 10, 2020
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734, jquery-ui, jquery-form, timeago (#8748)
fda2aed 
* feat: #8734, jquery-ui, jquery-form, timeago

get rid of forum/footer.js move that code to app.js & wait for app to load before calling ajaxify.end
make sockets.js a requirejs module
move jquery-ui to node_modules and load via requirejs
move jquery-form to node_modules and load via requirejs
move timeago to node_modules and load via requirejs
only include the css for needed jquery-ui widgets

* feat: keep socket/io global for backwards compat

* refactor: move socket listener to chat
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734, move bootbox to package.json
300a875
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734, move sortable to package.json
cc705e5
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734 remove unused files
c721625
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #5964, #8734 remove colorpicker
948f261
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734, move deserialize/serialize to package.json
eab7489
barisusakli added a commit that referenced this issue Oct 11, 2020
@barisusakli
feat: #8734, move bootstrap-tagsinput to package.json
f16c826
barisusakli added a commit that referenced this issue Oct 12, 2020
@barisusakli
feat: #8734, add slugify module, deprecate utils.slugify
bddfcb5
@barisusakli barisusakli unpinned this issue Oct 12, 2020
tdawgtimmy pushed a commit to EnContext/nodebb-theme-encontext that referenced this issue Mar 19, 2021
@barisusakli
https://github.com/NodeBB/NodeBB/issues/8734
f8fb8b8
@julianlam julianlam mentioned this issue Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barisusakli barisusakli

Labels
breaking change (plugins) enhancement
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
1 participant
@barisusakli