Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow guests to increment topic view counts #8821

Closed
andreadragotta opened this issue Nov 4, 2020 · 5 comments
Closed

allow guests to increment topic view counts #8821

andreadragotta opened this issue Nov 4, 2020 · 5 comments
Assignees
Milestone

Comments

@andreadragotta
Copy link

Hello everyone!

With my team we've found a curious bug.

The views are unique and only for logged in users.

I think that views shouldn't be unique and have to count all users, not only the logged in.

What do you think about that?

@barisusakli barisusakli self-assigned this Nov 4, 2020
@barisusakli
Copy link
Member

Will make this an option in the ACP so guests count towards views.

@andreadragotta
Copy link
Author

Ok, and for the unique view?
On ACP can set it or change the counting method?

@barisusakli
Copy link
Member

They are not unique, they only increment once per hour so you can't keep reloading the page and increment views. https://github.com/NodeBB/NodeBB/blob/master/src/controllers/topics.js#L132

@pitaj
Copy link
Contributor

pitaj commented Nov 4, 2020

Sounds like we should also make that time limit configurable.

@andreadragotta
Copy link
Author

Thank you @barisusakli
I think is interesting set the time limit configurable as @pitaj wrote

@barisusakli barisusakli added this to the 1.15.1 milestone Nov 6, 2020
@barisusakli barisusakli changed the title Topic Views error allow guests to increment topic view counts Nov 6, 2020
barisusakli added a commit that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants