Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that when thumbs have been uploaded, that they are discarded if composer is discarded #9042

Closed
julianlam opened this issue Dec 3, 2020 · 3 comments
Closed

Ensure that when thumbs have been uploaded, that they are discarded if composer is discarded #9042

julianlam opened this issue Dec 3, 2020 · 3 comments
Assignees
@julianlam
Labels
enhancement
Projects
Topic Thumbnail Refactor
Milestone
1.16.0

Comments

@julianlam
Copy link
Member

No description provided.

@julianlam julianlam created this issue from a note in Topic Thumbnail Refactor (To do) Dec 3, 2020
julianlam added a commit that referenced this issue Dec 3, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
6451989 
+ common data validation for thumb addition and deletion
@julianlam julianlam moved this from To do to In progress in Topic Thumbnail Refactor Dec 3, 2020
@barisusakli
Copy link
Member

Where are the thumbs stored? What if user closes browser tab are they deleted?

@julianlam
Copy link
Member Author

Thumbs are saved on server disk. If a composer window is closed, the draft is still valid and will be opened again when user loads the draft, so no special handling is required there.

@julianlam
Copy link
Member Author

Occasionally there may be cases where an upload is orphaned. In which case maybe a cleanup script is required.

julianlam added a commit that referenced this issue Dec 4, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
5a0f576 
+ common data validation for thumb addition and deletion
@julianlam julianlam added this to the 1.16.0 milestone Dec 4, 2020
@julianlam julianlam self-assigned this Dec 4, 2020
julianlam added a commit that referenced this issue Dec 4, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
980153e 
+ common data validation for thumb addition and deletion
julianlam added a commit that referenced this issue Dec 4, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
8929972 
+ common data validation for thumb addition and deletion
julianlam added a commit that referenced this issue Dec 8, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
597379c 
+ common data validation for thumb addition and deletion
julianlam added a commit that referenced this issue Dec 9, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
b0700ad 
+ common data validation for thumb addition and deletion
julianlam added a commit that referenced this issue Dec 9, 2020
@julianlam
feat: core work for #9042, thumb deletion now accepts uuids
b5d910f 
+ common data validation for thumb addition and deletion
@julianlam julianlam moved this from In progress to Done in Topic Thumbnail Refactor Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
enhancement
Projects
Topic Thumbnail Refactor
Done
Milestone
1.16.0
Development

No branches or pull requests
2 participants
@julianlam @barisusakli