fix: return at least one in sizeCalculation #10832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if post content is empty post cache should still consider its size to be at least one. fixes NodeBB#10831
julianlam
pushed a commit
that referenced
this pull request
Aug 15, 2022
if post content is empty post cache should still consider its size to be at least one. fixes #10831
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if post content is empty post cache should still consider its size to be one. Required since lru-cache only accepts positive integers in as return value of sizeCalulation.
Unless I missed something, post cache is the only cache instance in NodeBB that uses
maxSizeandsizeCalculation, so this should be the only place this bug exists.fixes #10831